Add information about number of tests and subtests #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrego
added a commit
to servo/servo.org
that referenced
this pull request
Apr 2, 2025
This is a companion of servo/internal-wpt-dashboard#56 Signed-off-by: Manuel Rego Casasnovas <[email protected]>
|
If this is merged we'll have to also land a change on the website so the new information is used there: servo/servo.org#233 |
This was referenced Apr 2, 2025
nicoburns
reviewed
Apr 3, 2025
There was a problem hiding this comment.
A comment:
- We could probably leave out the
per_mille_*fields here and compute them on the frontend if we wanted to. It's probably also fine to have them here. My concern is around keeping the filesize small.
A question:
- Is this format backwards compatible with the existing file? If not then we'll need to carefully time merging this with the website PR. (but it looks like it probably is?)
nicoburns
approved these changes
Apr 3, 2025
mukilan
reviewed
Apr 3, 2025
Yeah, I can do this so the size would be reduced a little bit.
No, it's not backwards compatible, when we land this we should also land #51 |
|
I have uploaded a new version fixing lint and adding a new test for the old vs new runs count, but I need to understand what we want to do there as I'm not sure about the numbers we have now. I haven't yet modified the |
mrego
force-pushed
the
wpt-subtests
branch
2 times, most recently
from
9d04a87 to
4d7d22e
Compare
|
I think the last version covers most of the comments, PTAL. Thanks. Before landing I need to update the website PR, but first I want to get agreement on this one in particular. |
mukilan
approved these changes
Apr 3, 2025
This modifies the scores.json file so it now provides more data: * total_tests: The total number of tests * total_score: The total scores for the tests * total_subtests: The total number of subtests * total_subtests_passed: The number of subtests that pass This is based on previous work by Delan Azabani at #35. This also creates a new output file scores-last-run.json with only the data of the last run. Co-authored-by: Delan Azabani <[email protected]> Signed-off-by: Manuel Rego Casasnovas <[email protected]>
mrego
added a commit
to servo/servo.org
that referenced
this pull request
Apr 3, 2025
This is a companion of servo/internal-wpt-dashboard#56 Signed-off-by: Manuel Rego Casasnovas <[email protected]>
mrego
added a commit
to servo/servo.org
that referenced
this pull request
Apr 3, 2025
This is a companion of servo/internal-wpt-dashboard#56 Signed-off-by: Manuel Rego Casasnovas <[email protected]>
mrego
added a commit
to servo/servo.org
that referenced
this pull request
Apr 3, 2025
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <[email protected]> Signed-off-by: Manuel Rego Casasnovas <[email protected]>
mrego
added a commit
to servo/servo.org
that referenced
this pull request
Apr 3, 2025
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <[email protected]> Signed-off-by: Manuel Rego Casasnovas <[email protected]>
mrego
added a commit
to servo/servo.org
that referenced
this pull request
Apr 3, 2025
This is a companion of servo/internal-wpt-dashboard#56 Co-authored-by: Mukilan Thiyagarajan <[email protected]> Signed-off-by: Manuel Rego Casasnovas <[email protected]>
|
Just for the record, the size of the generated files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information about number of tests and subtests
This modifies the scores.json file so it now provides more data:
This is based on previous work by Delan Azabani at #35.
This also creates a new output file scores-last-run.json
with only the data of the last run.