Skip to content

WIP: Rust score calculation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Feb 18, 2025

THIS PR IS NOT INTENDED FOR MERGING IN IT'S CURRENT FORM

Actual score calculation is implemented in the wptreport crate:

This PR adds a CI job to run the CLI from the crate on Github CI here with the purpose of seeing how fast the code runs on GIthub Actions.

@nicoburns
Copy link
Contributor Author

Ok: this PR is doing score recalculation in 2m 49s vs. 27m 8s on main. That's a pretty nice improvement!

@mukilan
Copy link
Member

mukilan commented Feb 20, 2025

The numbers look really promising! I've given the crate only a cursory read through - it seems like if the goal is to use this for Servo's WPT dashboard, the pending items are

  • A way to recalculate past runs by scoring them against a given run.
  • Support regex based areas to support /css/CSS2/tables & /css/css-tables. Doesn't have to be regex, I guess, we just need a way to combine arbitrary folders.
  • Few unit tests for confidence. Maybe just generating scores.json against a fixed dataset using the crate and diffing it against the current one would also work.

@nicoburns nicoburns force-pushed the rust-score-calculation branch from 993ecde to c8cc211 Compare May 1, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants