Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write depth buffer & view to registered RenderBuffer #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Write depth buffer & view to registered RenderBuffer #364

wants to merge 1 commit into from

Conversation

dorbie
Copy link

@dorbie dorbie commented Feb 1, 2018

depthStencilTextures and depthStencilViews vectors seem to be deprecated but leave for now

depthStencilTextures and depthStencilViews vectors seem to be deprecated but leave for now
Copy link
Contributor

@russell-taylor russell-taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense to go ahead and tell the RenderManager about the depth/stencil buffer but if we're doing that then it seems like it would also make sense to change the call to RenderView to get that information back out of the renderBuffers structure rather than continuing to send it directly.

There is at least one other example that uses this same approach that we could also change to work this way.

Copy link
Contributor

@russell-taylor russell-taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and it does indeed work to pull the view from the RenderInfo, so if you add that I'll go ahead and approve the request. We can then open an issue to change the other files to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants