Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports for 'request' and 'http' #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lorenzogm
Copy link

fix #16

@matiasbastos
Copy link

@lorenzogm I just tried this and seems to work https://itnext.io/automatically-remove-all-unused-typescript-imports-in-a-project-afd4eb0e84b7
Would you include it in your MR or want me to do a new one?

@lorenzogm
Copy link
Author

@matiasbastos I think you can add them. Anyway we need someone with write permissions to merge those PRs

@jomaora
Copy link

jomaora commented Mar 1, 2021

You think that this PR will take longtime to be merged and release?

@matiasbastos
Copy link

@matiasbastos I think you can add them. Anyway we need someone with write permissions to merge those PRs

Sorry for the delay, this evening will do it!

@aayush-sib
Copy link
Contributor

Hi
Please make all the required changes. I will discuss it with the team and then will proceed further.
Thanks for collaborating on the project.

@matiasbastos
Copy link

Hi @aayush-sib
Pushed my changes here #24

@lorenzogm
Copy link
Author

@aayush-sib can we merge this PR?

@aayush-sib
Copy link
Contributor

Hi @lorenzogm

Sorry for the delay, can you please create a branch from this project only and push changes to that branch instead of pushing it to the forked project?

Thanks!!

@yurist38 yurist38 mentioned this pull request Apr 6, 2021
@dkress59 dkress59 mentioned this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.x throwing type errors and errors on build
4 participants