v2.x throwing type errors and errors on build

[treyhuffine]

Upgraded from 1.2.1 to 2.0.2 and am getting errors. Doing pretty simple things like addings emails to contacts and sending a transactional email for account creation. The only change I made in my code was switching to the new transactional class name.

[aayush-sib]

Hi @treyhuffine
Try changing the value of module in tsconfig.json to commonjs, it might help.

[gmencz]

I'm also having this issue when running the build phase with NextJS, it's not an option to change the value of module in tsconfig.json because NextJS doesn't use that option during build.

[treyhuffine]

I'm using NextJS as well and seeing this issue. This is the only package I'm using that causes this problem, so I would imagine it could be resolved in the build phase to make it a more generally usable NPM package.

@gmencz I've downgraded to the 1.x package which still works if you need a quick fix.

[gmencz]

Thanks @treyhuffine downgrading seems to have fixed it, though I had to // @ts-ignore a bunch of typescript issues that I did not have with 2.x, at least now the build passes.

[matiasbastos]

Same issue here. Sadly had to downgrade to 1.x and hack some types to make it work 😞

[ThomasP1988]

3 releases after, the code is still not linted, and couldnt be used by lot of people, can you just lint your code please?

[nickfla1]

Same issue here, using NextJSl. This should really be considered a priority issue.
Let me know if you would accept incoming PRs.

[aayush-sib]

Hi @nickfla1
Thanks for helping out. You can raise the PR we will definitely look into it.

Sorry for the inconvenience, we are not able to replicate the issue at our end.

[lorenzogm]

I have created a PR @aayush-sib to fix this issue #23

Could you mind to review it and release it?

[aayush-sib]

Hi @treyhuffine @gmencz @matiasbastos @ThomasP1988 @nickfla1 Can you all please confirm if the changes are working fine in your projects?

[matiasbastos]

I'll give it a test later, but from the top of my head, I remember having a lot of unused imports giving error on build...

[aayush-sib]

Hi @lorenzogm @matiasbastos
I see there are 2 open PRs regarding this issue. Can you please close one PR so that I can proceed with the review process of the final PR?
Thanks!

[lorenzogm]

My PR #23 is to fix the errors described above in this issue. So maybe start reviewing that one.

@matiasbastos added something else that probably needs to be fixed as well, but it's not what we discussed in this issue.

[matiasbastos]

Well, #24 is also related to type errors on build but can create a new issue for my PR.

[aayush-sib]

Hi @matiasbastos
You can create a separate issue for your PR.

[matiasbastos]

@aayush-sib there you go #25

[aayush-sib]

Hi

I have released a beta tag https://www.npmjs.com/package/sib-api-v3-typescript/v/2.2.3-beta.1 for this. Can you please check if this is working well on your side?

[rennehir]

No activity in this for a looong time... I just happened to stumble on this issue. I got it fixed by using @sendinblue/[email protected] instead of the package called sib-api-v3-typescript. They seem to be the same but the latter hasn't been updated in a long long time.

[aayush-sib]

Hi
Our new package can be found on @sendinblue/client. As @rennehir mentioned the issue is not there in the latest version, so closing this issue.