Skip to content

chore: 🧑‍💻 use justfile as checklist in template #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: 🧑‍💻 use justfile as checklist in template #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76692b3
build: :hammer: very small updates to the justfile recipes
lwjohnst86 Nov 14, 2024
0a4ec22
chore: :technologist: simplify PR template to explain running `just r…
lwjohnst86 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,5 @@ This PR needs a quick/an in-depth review.
## Checklist

- [ ] Added or updated tests
- [ ] Tests passed locally
- [ ] Linted and formatted code
- [ ] Build passed locally
- [ ] Updated documentation
- [ ] Ran `just run-all`
7 changes: 4 additions & 3 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
@_default:
just --list --unsorted

run-all: install-deps format-python check-python run-tests check-commits build-website
# Run all the build recipes
run-all: reset-local install-deps format-python check-python test-python check-commits build-website

# Install Python package dependencies
install-deps:
Expand All @@ -15,8 +16,8 @@ generate-puml-all:
generate-puml name:
docker run --rm -v $(pwd):/puml -w /puml ghcr.io/plantuml/plantuml:latest -tsvg "**/{{name}}.puml"

# Run Python tests
run-tests:
# Run the Python tests
test-python:
poetry run pytest

# Check Python code with the linter for any errors that need manual attention
Expand Down