Skip to content

chore: 🧑‍💻 use justfile as checklist in template #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

lwjohnst86
Copy link
Member

Description

This PR makes very small updates to the justfile and simplifies the checklist in the PR template to tell submitter to run just run-all as a check.

This PR needs a quick review.

@lwjohnst86 lwjohnst86 requested a review from a team November 14, 2024 10:22
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Do we need to include build-website in run-all though?
It just takes a while to build the website and could be a bit annoying to have to do that every time you e.g., create a new function?

@lwjohnst86
Copy link
Member Author

@signekb you wouldn't run just run-all every time you commit, only right before pushing up to make a PR. Just so we can minimize the chance of build errors on the GitHub action side.

@signekb
Copy link
Member

signekb commented Nov 15, 2024

I also meant for creating a small PR like adding a new function - so not every commit, but every PR. But lets give it a try 👍

@lwjohnst86 lwjohnst86 merged commit b45679b into main Nov 15, 2024
1 check passed
@lwjohnst86 lwjohnst86 deleted the chore/update-justfile-and-pull-request-template branch November 15, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants