Skip to content

Commit

Permalink
Release 1.26.0
Browse files Browse the repository at this point in the history
  • Loading branch information
r-simlinger committed Jun 22, 2023
1 parent 029761f commit ec1582c
Show file tree
Hide file tree
Showing 7 changed files with 49 additions and 6 deletions.
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Removed


## [1.26.0] - 2023-06-22

### Deprecated
- Payment.Model.TransferAccount: deprecated the `account_owner`, `accountnumber` and `bankcode` parameter

### Added
- Payment.PaymentService.capture(): added `additional_data` parameter (optional)
- Payment.Model.Transaction: added `shop`, `shopversion` and `moduleversion` parameter
- Payment.Model.TransferAccount: added `owner` and `bankname` parameter

### Removed
- removed debug log `'Using config: '`


## [1.25.0] - 2023-01-24

### Changed
Expand Down Expand Up @@ -736,3 +750,4 @@ First release
[1.23.0]:https://github.com/secucard/secucard-connect-php-sdk/compare/1.22.0...1.23.0
[1.24.0]:https://github.com/secucard/secucard-connect-php-sdk/compare/1.23.0...1.24.0
[1.25.0]:https://github.com/secucard/secucard-connect-php-sdk/compare/1.24.0...1.25.0
[1.26.0]:https://github.com/secucard/secucard-connect-php-sdk/compare/1.25.0...1.26.0
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ You can install the bindings via [Composer](http://getcomposer.org/). Add this t
```json
{
"require": {
"secucard/secucard-connect":"^1.25.0"
"secucard/secucard-connect":"^1.26.0"
}
}
```
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "secucard connect PHP client SDK",
"license": "Apache-2.0",
"homepage": "https://github.com/secucard/secucard-connect-php-sdk",
"version": "1.25.0",
"version": "1.26.0",
"require": {
"php": ">=7.4.0",
"ext-json": "*",
Expand Down
15 changes: 15 additions & 0 deletions src/SecucardConnect/Product/Payment/Model/Transaction.php
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,19 @@ class Transaction extends BaseModel
* @var string
*/
public $payment_methods;

/**
* @var string
*/
public $shop;

/**
* @var string
*/
public $shopversion;

/**
* @var string
*/
public $moduleversion;
}
13 changes: 13 additions & 0 deletions src/SecucardConnect/Product/Payment/Model/TransferAccount.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,21 @@ class TransferAccount
{
/**
* @var string
* @deprecated use $owner
*/
public $account_owner;

/**
* @var string
* @deprecated use $iban
*/
public $accountnumber;

/**
* @var string
*/
public $owner;

/**
* @var string
*/
Expand All @@ -30,7 +37,13 @@ class TransferAccount

/**
* @var string
* @deprecated use $bic
*/
public $bankcode;

/**
* @var string
*/
public $bankname;

}
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,15 @@ public function cancel($paymentId, $contractId = null, $reduceAmountBy = null, $
*
* @param string $paymentId The payment transaction id
* @param string $contractId The id of the contract that was used to create this transaction.
* @param array $additional_data
* @return bool TRUE if successful, FALSE otherwise.
* @throws GuzzleException
* @throws ApiError
* @throws AuthError
* @throws ClientError
* @throws MissingParamsError
*/
public function capture($paymentId, $contractId = null)
public function capture($paymentId, $contractId = null, $additional_data = [])
{
if (empty($paymentId)) {
throw new MissingParamsError('paymentId', __METHOD__);
Expand All @@ -79,7 +80,7 @@ public function capture($paymentId, $contractId = null)
'contract' => $contractId,
];

$res = $this->execute($paymentId, 'capture', null, $object, $class);
$res = $this->execute($paymentId, 'capture', null, array_merge($additional_data, $object), $class);

if ($res) {
return true;
Expand Down
3 changes: 1 addition & 2 deletions src/SecucardConnect/SecucardConnect.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final class SecucardConnect
/**
* SDK version
*/
const VERSION = '1.25.0';
const VERSION = '1.26.0';

/**
* @var OAuthProvider
Expand Down Expand Up @@ -109,7 +109,6 @@ public function __construct(
$this->logger = $logger == null ? new Logger(null, false) : $logger;

$config->isValid();
$this->logger->debug('Using config: ' . json_encode($config->toArray(), JSON_PRETTY_PRINT));
$this->config = $config;

// Create the default common storage if necessary
Expand Down

0 comments on commit ec1582c

Please sign in to comment.