Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont pass breakpoints to swiper #1086

Merged
merged 1 commit into from
Jul 1, 2024
Merged

dont pass breakpoints to swiper #1086

merged 1 commit into from
Jul 1, 2024

Conversation

chrisFrazier77
Copy link
Contributor

No description provided.

@chrisFrazier77 chrisFrazier77 linked an issue Jun 27, 2024 that may be closed by this pull request
Swiper Navigation #989
Closed
@chrisFrazier77 chrisFrazier77 marked this pull request as ready for review June 27, 2024 17:17
@chrisFrazier77 chrisFrazier77 removed a link to an issue Jun 27, 2024
Swiper Navigation #989
Closed
@chrisFrazier77 chrisFrazier77 linked an issue Jun 27, 2024 that may be closed by this pull request
Carousel Breakpoints Pagination #981
Closed
korgon
korgon approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one-liner... seems scary, but I think this ought to be fine, as we are already passing on the props to Swiper via our own breakpoints.

@korgon korgon merged commit 3c3e8b8 into develop Jul 1, 2024
1 check passed
@korgon korgon deleted the carousel-bugfix branch July 1, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel Breakpoints Pagination
2 participants
@chrisFrazier77 @korgon