Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiper Navigation #989

Closed
adriamurphy opened this issue Feb 5, 2024 · 0 comments · Fixed by #1084 or #1085
Closed

Swiper Navigation #989

adriamurphy opened this issue Feb 5, 2024 · 0 comments · Fixed by #1084 or #1085
Assignees

Comments

@adriamurphy
Copy link

With swiper, there is a class that gets added (swiper-button-disabled) when the previous or next buttons are disabled, meaning you can't paginate. However, it looks like this class does not get reset on page resize.

For example, if I set the limit of results to 4 with slides per view as 5 on a desktop carousel, the next button has two classes ss__carousel__next-wrapper--hidden and swiper-button-disabled (correct):
https://capture.dropbox.com/YmWIhvzSjNyFMtXB

On smaller breakpoints, if I set slides per view to 2 and can now paginate, swiper-button-disabled remains but ss__carousel__next-wrapper--hidden goes away:
https://capture.dropbox.com/y1pSx9JFkcRGGarL

From a CSS perspective, we can just use ss__carousel__next-wrapper--hidden for styling instead, but another reason to look into this might be regarding the aria-disabled="true" attribute saying the button is hidden when it's not. A page refresh does fix this, but right now the class removal and attribute update is not consistent.

@chrisFrazier77 chrisFrazier77 self-assigned this Jun 25, 2024
@korgon korgon mentioned this issue Jun 26, 2024
@chrisFrazier77 chrisFrazier77 linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants