Skip to content

Condensed api ref layout #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 22, 2025
Merged

Condensed api ref layout #596

merged 28 commits into from
May 22, 2025

Conversation

mikewuu
Copy link
Contributor

@mikewuu mikewuu commented May 16, 2025

Closes https://linear.app/seam/issue/CX-318/condensed-layout-for-docs

Implements the changes made in #548 based off latest main

@mikewuu mikewuu requested review from a team as code owners May 16, 2025 03:45
@mikewuu
Copy link
Contributor Author

mikewuu commented May 16, 2025

@DebbieAtSeam, I tried my best copy changes from the diff in #548 . Some of the files have been updated significantly so I had to make changes by hand.

Hopefully I didn't break anything 🤞

@DebbieAtSeam
Copy link
Member

Looks excellent! Thanks so much! Some comments:

  • One of us needs to move the table of contents entries around to match what's in Condense api ref layout #548. It's alpha.
  • Need a line break here, and format, etc. should go on the same line as the prop name (like the top-level props).
    image
  • Nested enum lists need HTML formatting (I think HTML vs. MD is how we got it to work.).
    image
  • Something needs to be fixed with this bulleted list of child props.
    image
  • Something seems to be missing in endpoint request params.
    image
  • Is it possible to add a horizontal line between code example blocks when there are multiple code examples?
    Thanks!

@mikewuu mikewuu force-pushed the condensed-api-v2 branch from a9e0656 to f55da16 Compare May 21, 2025 02:45
@mikewuu mikewuu force-pushed the condensed-api-v2 branch from 64cd838 to 8625455 Compare May 21, 2025 03:26
@@ -3,7 +3,6 @@
* [Seam Documentation](README.md)
* [🚲 Quick Start](quickstart.md)
* [🚀 Go Live!](go-live.md)
* [Contact Us](contact-us.md)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of us needs to move the table of contents entries around to match what's in #548. It's alpha.

@DebbieAtSeam, copied over the docs summary in b635346, is there anything else required for this?

@@ -1,5 +1,4 @@
**`{{name}}`**
Format: `{{format}}`{{#if listItemFormat}}, Item format: `{{listItemFormat}}`{{/if}}
**`{{name}}`** Format: `{{format}}`{{#if listItemFormat}}, Item format: `{{listItemFormat}}`{{/if}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a line break here, and format, etc. should go on the same line as the prop name (like the top-level props).

Updated in f55da16

<details>
<summary>Enum values</summary>
{{#each enumValues}}
- <code>{{this}}</code>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested enum lists need HTML formatting (I think HTML vs. MD is how we got it to work.).

Updated to use <code> instead in 8625455


{{/each}}
{{#each objectProperties}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something needs to be fixed with this bulleted list of child props.

Fixed in 52fb020, just needed an extra line

Item format: `{{this.itemFormat}}`
{{/if}}
Required: {{#if this.required}}Yes{{else}}No{{/if}}
**`{{this.name}}`** {{#if this.jsonType}}*{{this.jsonType}}*{{/if}}{{#if this.itemFormat}} *of {{this.itemFormat}}s*{{/if}}{{#if this.required}} (Required){{/if}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems to be missing in endpoint request params.

Fixed in 9e96cc8. Was due to certain params not having a jsonType defined.


{{#each additionalCodeSamples}}
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a horizontal line between code example blocks when there are multiple code examples?

Yep, updated in b578dd1

See /docs/api/acs/users/create.md > Create a new ACS User for an example.

@mikewuu mikewuu requested a review from DebbieAtSeam May 21, 2025 03:55
@DebbieAtSeam
Copy link
Member

Many thanks, @mikewuu! Found just a couple more things...

  • Could the format of these child props please match the way it's rendered for higher-level props?
    image

  • Just realized that we have errors and warnings twice on the resource pages. Only the top version has the props though. Let's ask @razor-x what he thinks. Is it superfluous to have them in both places? Which place (or both) should have the props?

  • it looks like some child props are being rendered as bulleted lists and some as horizontal line-separated lists with no bullets. Let's pick one and use it throughout. I think I prefer the hr-separated lists with no bullets, but I'm not totally sure.

Thanks!

@razor-x
Copy link
Member

razor-x commented May 21, 2025

@DebbieAtSeam @mikewuu This PR is quite large now and has been open for a week. Please consider if any of the feedback or changes are blocking or not. If the current PR changes overall improve the docs, we can merge this and still fix the other items as a follow up :)

@mikewuu
Copy link
Contributor Author

mikewuu commented May 22, 2025

Could the format of these child props please match the way it's rendered for higher-level props?

@DebbieAtSeam do you mean to have it in italics?

@mikewuu
Copy link
Contributor Author

mikewuu commented May 22, 2025

@DebbieAtSeam @mikewuu This PR is quite large now and has been open for a week. Please consider if any of the feedback or changes are blocking or not. If the current PR changes overall improve the docs, we can merge this and still fix the other items as a follow up :)

@DebbieAtSeam should we just merge this now, and I'll open new PRs immediately for the new points in #596 (comment), to make the review easier?

@DebbieAtSeam
Copy link
Member

Sure, you can merge it. I would like it if we could fix the last two remaining things in a follow up PR though. Thanks!

@razor-x razor-x merged commit 9dc2287 into main May 22, 2025
14 checks passed
@razor-x razor-x deleted the condensed-api-v2 branch May 22, 2025 17:13
Comment on lines +10 to +16
<details>
<summary>Enum values:</summary>

{{> enum-values}}
{{#each enumValues}}
- <code>{{this}}</code>
{{/each}}
</details>
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikewuu Gitbook can't render nested details tags, so we can't use the tag here because it's used in property-collapsible partial which also uses details tag.

This property-content partial is also used in property-non-collapsible which you used in api-resource partial which also uses details tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so are we good to just remove it from here?

Copy link
Contributor

@andrii-balitskyi andrii-balitskyi May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, something similar was implemented previously with the enum-values partial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Updated in #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants