Skip to content

fix: separate properties with --- #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2025
Merged

fix: separate properties with --- #608

merged 2 commits into from
May 25, 2025

Conversation

mikewuu
Copy link
Contributor

@mikewuu mikewuu commented May 23, 2025

Follow up for #596.

Addresses comment:

it looks like some child props are being rendered as bulleted lists and some as horizontal line-separated lists with no bullets. Let's pick one and use it throughout. I think I prefer the hr-separated lists with no bullets, but I'm not totally sure.

Updates properties to be separated with ---.

I've left child properties as is (with bullet list).

@mikewuu mikewuu requested a review from a team as a code owner May 23, 2025 09:32
@seambot seambot requested a review from a team as a code owner May 23, 2025 09:32
@mikewuu mikewuu requested a review from DebbieAtSeam May 24, 2025 04:26
@mikewuu mikewuu merged commit 4e77f13 into main May 25, 2025
14 checks passed
@mikewuu mikewuu deleted the line-properties branch May 25, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebbieAtSeam DebbieAtSeam DebbieAtSeam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikewuu @DebbieAtSeam @seambot