-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm_arm: use gic path to find phandle #52
Conversation
welp theres a |
53b3f30
to
33a4a52
Compare
@@ -164,7 +164,7 @@ static const int free_plat_interrupts[] = { 220 + GIC_LIC_INTID_BASE }; | |||
#define DTB_ADDR (LINUX_RAM_BASE + 0x01000000) | |||
#define INITRD_MAX_SIZE 0x1900000 //25 MB | |||
#define INITRD_ADDR (DTB_ADDR - INITRD_MAX_SIZE) //0x80700000 | |||
#define GIC_IRQ_PHANDLE 0x1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the GIC_NODE_PATH has to match with the name in the DTS, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
This commit defines the gic path for each platform, which is used to parse the device tree to find the gic phandle, instead of relying on the user to provide the correct value. Signed-off-by: Chris Guikema <[email protected]>
33a4a52
to
2a79348
Compare
Test with: seL4/seL4_projects_libs#83 |
2a79348
to
f0ce920
Compare
f0ce920
to
5f2770e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now
The builds fail with |
I'm going to break this up into 2 PRs, so we can get the phandle through, without needing to modify the vm struct. |
5f2770e
to
3e2268d
Compare
This commit defines the gic path for each platform, which is used to parse the device tree to find the gic phandle, instead of relying on the user to provide the correct value.
I could use some help to validate that this functions properly. I did my best to find the proper gic for each platform, but I may have messed things up.
#49