vm_arm: use gic path to find phandle #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
reviewed
Oct 27, 2022
axel-h
reviewed
Oct 27, 2022
|
welp theres a |
chrisguikema
force-pushed
the
phandle_gen
branch
from
53b3f30
to
33a4a52
Compare
yyshen
approved these changes
Oct 27, 2022
| @@ -164,7 +164,7 @@ static const int free_plat_interrupts[] = { 220 + GIC_LIC_INTID_BASE }; | |||
| #define DTB_ADDR (LINUX_RAM_BASE + 0x01000000) | |||
| #define INITRD_MAX_SIZE 0x1900000 //25 MB | |||
| #define INITRD_ADDR (DTB_ADDR - INITRD_MAX_SIZE) //0x80700000 | |||
| #define GIC_IRQ_PHANDLE 0x1 | |||
There was a problem hiding this comment.
This means that the GIC_NODE_PATH has to match with the name in the DTS, right?
axel-h
reviewed
Oct 27, 2022
This commit defines the gic path for each platform, which is used to parse the device tree to find the gic phandle, instead of relying on the user to provide the correct value. Signed-off-by: Chris Guikema <[email protected]>
chrisguikema
force-pushed
the
phandle_gen
branch
from
33a4a52
to
2a79348
Compare
|
Test with: seL4/seL4_projects_libs#83 |
axel-h
reviewed
Oct 27, 2022
chrisguikema
force-pushed
the
phandle_gen
branch
from
2a79348
to
f0ce920
Compare
axel-h
reviewed
Oct 27, 2022
chrisguikema
force-pushed
the
phandle_gen
branch
from
f0ce920
to
5f2770e
Compare
|
The builds fail with |
|
I'm going to break this up into 2 PRs, so we can get the phandle through, without needing to modify the vm struct. |
chrisguikema
force-pushed
the
phandle_gen
branch
from
5f2770e
to
3e2268d
Compare
kent-mcleod
approved these changes
Oct 27, 2022
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit defines the gic path for each platform, which is used to parse the device tree to find the gic phandle, instead of relying on the user to provide the correct value.
I could use some help to validate that this functions properly. I did my best to find the proper gic for each platform, but I may have messed things up.
#49