-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont hard-code GIC_IRQ_PHANDLE, read it from device tree instead #49
Comments
Can we define an |
What about getting the phandle by looking up the interrupt parent of the primary boot core? |
Is that something that is consistent on a per-platform basis? Here is the boot core node on a zynqmp device tree:
On a tx2 device tree, I see |
I see. I guess defining the path is good enough. It could also be used to setup the virtual gic without having to hardcode the addresses for each platform. |
Created a PR for that here: seL4/seL4_projects_libs#83 |
Closing this, because #52 was merged and we use DTB paths now. |
Follow-up from #42 (comment)
Remove the hard coded
GIC_IRQ_PHANDLE
define and take the value from the device tree instead. Or add at least a sanity check that the hard-coded values machtes the device tree.There have been cases, where the
phande
changes, and that causes strange errors then.See also #27
The text was updated successfully, but these errors were encountered: