Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(_get_keyspaces_to_decrease_rf): Address a case where no keyspace RF value of DC #8695

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

yarongilor
Copy link
Contributor

@yarongilor yarongilor commented Sep 15, 2024

In case no keyspace replication-factor value is retrieved in a DC,
A warning is logged and the keyspace is ignored (skipped).

Fixes: #8694

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@yarongilor yarongilor added backport/6.0 backport/2024.2 Need backport to 2024.2 backport/6.1 Need backport to 6.1 labels Sep 15, 2024
@yarongilor yarongilor changed the title fix(_get_keyspaces_to_decrease_rf): Address a case where no keyspace … fix(_get_keyspaces_to_decrease_rf): Address a case where no keyspace RF value of DC Sep 15, 2024
@yarongilor
Copy link
Contributor Author

yarongilor commented Sep 15, 2024

Running a small test in https://argus.scylladb.com/test/e6972842-591d-472f-9e39-f196d3670053/runs?additionalRuns[]=5e71277b-52d8-4fa9-ad60-8221d766f887

==> passed ok.
output example:

< t:2024-09-15 09:13:34,051 f:replication_strategy_utils.py l:185  c:sdcm.utils.replication_strategy_utils p:WARNING > Datacenter eu-west_nemesis_dc not found in replication strategy for keyspace keyspace1.
< t:2024-09-15 09:13:34,062 f:replication_strategy_utils.py l:185  c:sdcm.utils.replication_strategy_utils p:WARNING > Datacenter eu-west_nemesis_dc not found in replication strategy for keyspace mview.
< t:2024-09-15 09:13:34,062 f:replication_strategy_utils.py l:185  c:sdcm.utils.replication_strategy_utils p:WARNING > Datacenter eu-west_nemesis_dc not found in replication strategy for keyspace keyspace_new_dc.
< t:2024-09-15 09:13:36,256 f:db_log_reader.py l:125  c:sdcm.db_log_reader   p:DEBUG > 2024-09-15T09:13:36.196+00:00 add-remove-dc-master-db-node-5e71277b-1     !INFO | scylla[6600]:  [shard 0: gms] load_balancer - Examining DC eu-west_nemesis_dc (shuffle=false, balancing=true)
< t:2024-09-15 09:13:36,256 f:db_log_reader.py l:125  c:sdcm.db_log_reader   p:DEBUG > 2024-09-15T09:13:36.196+00:00 add-remove-dc-master-db-node-5e71277b-1     !INFO | scylla[6600]:  [shard 0: gms] load_balancer - Will drain node e5a06229-bdbe-4fa9-b8a2-d96a9bcc7a50 (being_decommissioned) from DC eu-west_nemesis_dc

@fruch
Copy link
Contributor

fruch commented Sep 15, 2024

@yarongilor please stop adding unneed spaces in commits/descriptions

@yarongilor yarongilor requested review from fruch and soyacz September 15, 2024 10:11
…RF value of DC

In case no keyspace replication-factor value is retrieved in a DC,
A warning is logged and the keyspace is ignored (skipped).
Fixes: scylladb#8694
@yarongilor yarongilor force-pushed the fix_get_keyspaces_to_decrease_rf branch from 50cea6f to f877c9b Compare September 15, 2024 10:30
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_get_keyspaces_to_decrease_rf isn't safe enough
3 participants