Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 6.1] fix(_get_keyspaces_to_decrease_rf): Address a case where no keyspace RF value of DC #8702

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 15, 2024

In case no keyspace replication-factor value is retrieved in a DC,
A warning is logged and the keyspace is ignored (skipped).

Fixes: #8694

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit e57d75b)

Parent PR: #8695

…RF value of DC

In case no keyspace replication-factor value is retrieved in a DC,
A warning is logged and the keyspace is ignored (skipped).
Fixes: #8694

(cherry picked from commit e57d75b)

# Conflicts:
#	sdcm/utils/replication_strategy_utils.py
Copy link
Author

mergify bot commented Sep 15, 2024

Cherry-pick of e57d75b has failed:

On branch mergify/bp/branch-6.1/pr-8695
Your branch is up to date with 'origin/branch-6.1'.

You are currently cherry-picking commit e57d75b34.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdcm/utils/replication_strategy_utils.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft September 15, 2024 11:53
@yarongilor
Copy link
Contributor

Addressed in #8547

@yarongilor yarongilor closed this Sep 18, 2024
@mergify mergify bot deleted the mergify/bp/branch-6.1/pr-8695 branch September 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant