Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it use DCAwareRoundRobinPolicy unless rack is provided #21

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Sep 5, 2024

Currently c-s uses RackAwareRoundRobinPolicy in any case which leads it targeting particular rack only, even if rack is not provided.

This PR makes it use DCAwareRoundRobinPolicy unless rack is provided.

Closes #20

@dkropachev
Copy link
Collaborator Author

@fruch , can you please take a look at it.

Copy link

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link

fruch commented Sep 5, 2024

There is still a question, if we need this fix "backported" into scylla-tools repo, and to releases

@fruch
Copy link

fruch commented Sep 5, 2024

Also meanwhile I think we might have persuaded those who reported this to switch to use latte and not c-s...

@dkropachev
Copy link
Collaborator Author

There is still a question, if we need this fix "backported" into scylla-tools repo, and to releases

100% needs to be ported.

Copy link
Collaborator

@CodeLieutenant CodeLieutenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeLieutenant CodeLieutenant merged commit 6bf5aff into scylladb:master Sep 6, 2024
2 checks passed
fruch added a commit to fruch/scylla-tools-java that referenced this pull request Sep 12, 2024
Currently c-s uses RackAwareRoundRobinPolicy in any case which leads it targeting particular rack only, even if rack is not provided.

This PR makes it use DCAwareRoundRobinPolicy unless rack is provided.

Ref: scylladb/cassandra-stress#20
Ref: scylladb/cassandra-stress#21
denesb pushed a commit to scylladb/scylla-tools-java that referenced this pull request Sep 12, 2024
Currently c-s uses RackAwareRoundRobinPolicy in any case which leads it targeting particular rack only, even if rack is not provided.

This PR makes it use DCAwareRoundRobinPolicy unless rack is provided.

Ref: scylladb/cassandra-stress#20
Ref: scylladb/cassandra-stress#21

Closes: #404
CodeLieutenant added a commit to CodeLieutenant/scylla-cluster-tests that referenced this pull request Nov 21, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant added a commit to CodeLieutenant/scylla-cluster-tests that referenced this pull request Nov 21, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant added a commit to CodeLieutenant/scylla-cluster-tests that referenced this pull request Nov 23, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant added a commit to CodeLieutenant/scylla-cluster-tests that referenced this pull request Nov 23, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)

# Conflicts:
#	defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)

# Conflicts:
#	defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)

# Conflicts:
#	defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
mergify bot pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 26, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 27, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 27, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 27, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 27, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 28, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 28, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 28, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 28, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 28, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)

# Conflicts:
#	defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Dec 1, 2024
Main reason for version change:

Using cassandra-stress 3.17 to mittigate
- Switch to ReplicaOrdering.RANDOM for select LBPs
  [32](scylladb/cassandra-stress#32)

Other Noticable Changes since the last version used in SCT:

- Add support for hostname verification
  [31](scylladb/cassandra-stress#31)
- Print thread dump on specific signals
  [27](scylladb/cassandra-stress#27)
- Replace uninterruptible wait
  [26](scylladb/cassandra-stress#26)
- Make it use DCAwareRoundRobinPolicy unless rack is provided
  [21](scylladb/cassandra-stress#21)
- feature(docker): adding support for dependabot
  [19](scylladb/cassandra-stress#19)

Signed-off-by: Dusan Malusev <[email protected]>
(cherry picked from commit 02997a6)

# Conflicts:
#	defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RackAwareRoundRobinPolicy shouldn't be used by default if rack wasn't specified in commandline
3 participants