Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform "unstable" example into an "new JSON-RPC" example #798

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Transform "unstable" example into an "new JSON-RPC" example #798

merged 1 commit into from
Sep 2, 2024

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Aug 28, 2024 •
edited
Loading

The calls in the example are not unstable anymore so the name does not make sense anymore

  • Change the file name as the calls are not unstable anymore
  • Given that the calls are stable we don't need to verify that they exist
    Also see comments in issue Incorporate stabilized APIs #779

@Niederb Niederb self-assigned this Aug 28, 2024
@Niederb
- Change the file name as the calls are not unstable anymore
7ae56d4 
- Given that the calls are stable we don't need to verify that they exist
@Niederb Niederb linked an issue Aug 28, 2024 that may be closed by this pull request
Incorporate stabilized APIs #779
Closed
@Niederb Niederb mentioned this pull request Aug 28, 2024
Closed
@Niederb Niederb marked this pull request as ready for review August 28, 2024 09:43
@Niederb Niederb requested a review from masapr August 28, 2024 09:43
masapr
masapr approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Niederb Niederb merged commit feafbab into master Sep 2, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masapr masapr masapr approved these changes

Assignees

@Niederb Niederb

Labels
E1-breaksnothing F3-test fix tests or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate stabilized APIs
2 participants
@Niederb @masapr