Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate stabilized APIs #779

Closed
Niederb opened this issue Jun 19, 2024 · 1 comment · Fixed by #798
Closed

Incorporate stabilized APIs #779

Niederb opened this issue Jun 19, 2024 · 1 comment · Fixed by #798

Comments

@Niederb
Copy link
Contributor

Niederb commented Jun 19, 2024 •
edited
Loading

The functions we test in unstable_rpc_api_calls.rs were stabilized:
paritytech/polkadot-sdk#1156
paritytech/polkadot-sdk#1508

We should provide these functions as actual API functions.
This was referenced Jun 26, 2024
Merged
Merged
@Niederb
Copy link
Contributor Author

Niederb commented Aug 28, 2024 •
edited
Loading

After looking a bit more into this it is my understanding that the stabilized calls are part of the new JSON-RPC and do not offer anything fundamentally new. So it does not make sense to incorporate the calls in the API. Instead we should think about how/when to migrate to the new JSON-RPC. See #764 for that.
I opened PR #798 to rename the example as the name does not make sense anymore.

@Niederb Niederb linked a pull request Aug 28, 2024 that will close this issue
Transform "unstable" example into an "new JSON-RPC" example #798
Merged
@Niederb Niederb mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transform "unstable" example into an "new JSON-RPC" example scs/substrate-api-client
1 participant
@Niederb