Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hebrew Keyboard update to HEInterfaceKeyboard.swift #495
Hebrew Keyboard update to HEInterfaceKeyboard.swift #495
Changes from 8 commits
00cc0b1
215b291
caa11fe
a4dff68
5f6243a
cbd5f4c
e18c0ab
b1fa593
61e8bfc
65f2f2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 10 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it, we have
space
andreturn
in the Russian keyboard, so I think these should be reverted. Not ABC, that's correct, but the actual Hebrew for these keys will be substituted in later, or for return it similarly will be an icon like forX
:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Check failure on line 51 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 90 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 120 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 124 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 133 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 139 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 148 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 154 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
Check failure on line 156 in Keyboards/LanguageKeyboards/Hebrew/HEInterfaceVariables.swift
GitHub Actions / Run SwiftLint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this is where the spacebars text is replaced :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or set up to be replaced 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in the rest of the code should it still be the english "Space"? or is replacing it with hebrew like I did fine? Same apply for the enter/return button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also similarly need these to be localized into Hebrew :) Same for Conjugate and Plural.