Hebrew Keyboard update to HEInterfaceKeyboard.swift #495
Conversation
Added temp file to make edits to and rewrite the code. Want to keep the old one as a reference.
Started to add basic required variables and importing UIKit
Started to add alternate letters
Added all the phone keyboards to temp. Including all the correct signs and words.
Added all the iPad and Larger iPad keyboards with correct signs and button labels
added the two bottom functions and removed the alternate keys, upon further thought hebrew doesn't require the alternate letters for functioning and can be used without them. We can add them later if needed but as far as i'm aware they arent mandatory
Added in conjugation, plural and translate. Based off of the Russian and english
Removed the old interface variables file and renamed the new one to the appropriate name.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
| .addRow(["123", ".", ",", "?", "!", "'", "delete"]) | ||
| .addRow(["ABC", "selectKeyboard", "space", "return"]) // "undo", "accent" | ||
| .addRow(["123", ".", ",", "?", "!", "'", "❌"]) | ||
| .addRow(["אבג", "selectKeyboard", "רווח", "הכנס"]) |
There was a problem hiding this comment.
Looking at it, we have space and return in the Russian keyboard, so I think these should be reverted. Not ABC, that's correct, but the actual Hebrew for these keys will be substituted in later, or for return it similarly will be an icon like for X :)
|
|
||
| currencySymbol = "" | ||
| currencySymbolAlternates = roubleAlternateKeys | ||
| spaceBar = "רווח" |
There was a problem hiding this comment.
See this is where the spacebars text is replaced :)
There was a problem hiding this comment.
So in the rest of the code should it still be the english "Space"? or is replacing it with hebrew like I did fine? Same apply for the enter/return button?
| baseAutosuggestions = ["אתמ", "אני", "היי"] | ||
| numericAutosuggestions = ["", "", ""] | ||
|
|
||
| translateKeyLbl = "Translate" |
There was a problem hiding this comment.
We also similarly need these to be localized into Hebrew :) Same for Conjugate and Plural.
|
The above comments are the main things here, @DanielGevaZA! From there it looks like you also have some swiftlint errors that need to be attended to. Let me know if there's anything I can do to help or if you have any questions! Thanks for this! :) |
Fixed some of the issues mentioned in the PR
|
Just did a quick format of the file and translated some words, but could you check that what I put in there is correct for things like "Translate", "Conjugate", "Conjugation: ", "Plural", and "Already in plural form"? Aside from that, is there a different version of a colon for Hebrew? So for "Conjugation: " I did the translation, the colon on the left and a space after it? This would be the header within the command bar when a user is selecting a conjugation for a given verb :) Let me know on the above and we'll be able to bring this in! Note that if you want to make changes here, first pull my most recent commit down. I figure you know this, but just want to make sure 😇 |
|
Will check the spelling/translation now. Thanks for helping with the formatting. |
|
All looks good with the translations, Yes you can use the colon in hebrew but it is less common. Isnt really an alternative so a : can be used. |
|
Very happy to help with the formatting, and thanks for checking the changes! :) |
There was a problem hiding this comment.
Thanks for a first great contribution, @DanielGevaZA! Happy that we're starting on this journey of Hebrew and RTL support for Scribe 😊 Let's discuss next steps in the issue :)
Contributor checklist
Description
Related issue