Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed opening_brace from disabled rules in .swiftlint.yml #443

Merged
merged 1 commit into from
May 18, 2024

Conversation

mostazomarc
Copy link
Contributor

Contributor checklist


Description

Removed opening_brace as a disabled rule from .swiftlint.yml and fixed all errors for it in the codebase.

The linter fix was tested running: swiftlint --no-cache --config ~/com.raywenderlich.swiftlint.yml and tested on:

  • iPhone 15 Pro Max, iOS 17.4. (simulator)

Related issue

@mostazomarc mostazomarc changed the title #426 removed opening_brace from disabled rules in .swiftlint.yml Removed opening_brace from disabled rules in .swiftlint.yml May 18, 2024
Copy link

github-actions bot commented May 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review May 18, 2024 15:58
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one especially cleans things up really well, @mostazomarc! Thanks for it! 😊

@andrewtavis andrewtavis merged commit f5ecbd9 into scribe-org:main May 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants