Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint: Fix opening_brace throughout codebase #426

Closed
2 tasks done
andrewtavis opened this issue May 16, 2024 · 3 comments
Closed
2 tasks done

SwiftLint: Fix opening_brace throughout codebase #426

andrewtavis opened this issue May 16, 2024 · 3 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 16, 2024

Terms

Description

Work for this issue would remove opening_brace as a disabled rule from .swiftlint.yml and fix all errors for it in the codebase.

Docs for opening_brace are here: https://realm.github.io/SwiftLint/opening_brace.html

We'd know that this is successful if our SwiftLint pull request workflow passes on the pull request for the change 🚀

Contribution

This would be a great good first issue for someone wanting to start with Scribe-iOS development. Happy to support! 😊

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 16, 2024
@mostazomarc
Copy link
Contributor

I'll be working on it!

@andrewtavis
Copy link
Member Author

Nice, @mostazomarc! Thanks for picking up so many of these 😊

@andrewtavis
Copy link
Member Author

Closed via #443 🚀 Appreciate all the work here, @mostazomarc! Again, let me know on if showing up to a dev sync would be of interest at some point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants