Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix noun-gender annotation formatting on device orientation change #396 #406

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Taufi
Copy link
Contributor

@Taufi Taufi commented Mar 16, 2024

Contributor checklist

Description

The pull request provides a solution for issue 396: noun-gender annotation formatting broken on device orientation change. In the app, annotation size and position is calculated depending on the frame of the assigned keys. I think the error occurs when auto layout changes the frames. To fix the bug, I called loadKeys() again when auto layout is finished.

The fix is tested on

  • iPhone 12, iOS 17.3.1. (physical device)
  • iPhone 15, iOS 17.0. (simulator)
  • iPhone 15 Pro, iOS 17.0. (simulator)
  • iPad (10th generation), iOS 17.0 (simulator)
  • iPhone SE (3rd generation), iOS 17.0 (simulator)

Related issue

Copy link

github-actions bot commented Mar 16, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review March 17, 2024 15:15
@andrewtavis
Copy link
Member

Thanks so much for the commit here, @Taufi! I'll hopefully be able to bring this in soon 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great first contribution, @Taufi! Thank you so much for looking into all of this and devising such a great solution 😊 Let us know if there are others issues you'd have interest working on!

@andrewtavis andrewtavis merged commit e32fbb7 into scribe-org:main Mar 21, 2024
@Taufi Taufi deleted the annotation-formatting branch March 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants