Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noun-gender annotation formatting broken on device orientation change #396

Closed
henrikth93 opened this issue Jan 14, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@henrikth93
Copy link
Member

henrikth93 commented Jan 14, 2024

          From issue #388
  • The transition is great!
  • Sometimes the keys are not exactly sized the way they should be, but it's a major improvement
  • Looks like it might be good to call the annotation function one more time after the transition?
    • We can discuss in the sync, but for me with the German keyboard the annotation bar under words shifts afterwards, but after I start typing it looks ok again (see screenshots)

Simulator Screenshot - iPhone 15 Pro - 2024-01-13 at 14 17 44

Simulator Screenshot - iPhone 15 Pro - 2024-01-13 at 14 18 04

After fixing that we should be good to go! 🚀

Originally posted by @andrewtavis in #388 (comment)

@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 14, 2024
@andrewtavis andrewtavis changed the title Annotation issues Noun-gender annotation formatting broken on device orientation change Jan 14, 2024
@andrewtavis
Copy link
Member

Thanks for making the issue, @henrikth93! I'd be happy to support someone with interest in working on this, and I'm sure @henrikth93 would be as well 😊

andrewtavis added a commit that referenced this issue Mar 21, 2024
fix noun-gender annotation formatting on device orientation change #396
@andrewtavis
Copy link
Member

Closed via #406 🥳 Thank you, @Taufi! Would be very happy to work with you again 😊

@Taufi
Copy link
Contributor

Taufi commented Mar 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants