#362 Changed the expanded keyboard for more languages

[henrikth93]

Contributor checklist

• [] This pull request is on a separate branch and not the main branch

---

Description

Related issue

• Size keys on expanded iPad keyboards #362

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[wkyoshida]

nit - Would it make sense to already check (disableAccentCharacters && keyboardState != .symbols) just once before and then simply use the boolean result in the switch statement? The boolean statements for the ternary operators here are simply repeated really.

OR..
(can most definitely be a TODO for later but..) would it be possible to abstract the logic for the values to the specific language somewhere else? So that only something like the below is possible with no switch statement needed?

        scalarCapsLockKeyWidth = currentLanguage.scalarCapsLockKeyWidth 
        scalarReturnKeyWidth = currentLanguage.scalarReturnKeyWidth
        scalarSpecialKeysWidth = currentLanguage.scalarSpecialKeysWidth
        scalarReturnKeyWidth = currentLanguage.scalarReturnKeyWidth

Scribe-iOS isn't my domain, so let me know if I'm talking crazy 😆

[andrewtavis]

Either sounds good to me! What are your thoughts on this, @henrikth93?

And all of Scribe is your domain, @wkyoshida 😊🤗

[henrikth93]

I think Will's idea of abstracting it is good, and that is something I can try and solve. @wkyoshida I am not sure I understand what you mean regarding the ternary operators, but do you mean that just checking the statement once would be less consuming? To tell the truth, my understanding of ternary operators and what they do under the hood is lacking.

[henrikth93]

@wkyoshida @andrewtavis I think the logic for setting the values could be moved to interfacevariables maybe

[wkyoshida]

Hey! 👋

I am not sure I understand what you mean regarding the ternary operators, but do you mean that just checking the statement once would be less consuming?

Oh no, not really 😄 I just meant that since the boolean statements for them is the same, could just write it once, store the result in a variable, then consult the variable in each ternary. It's really just more of a visual suggestion to declutter the code a bit to make it more visually clean - that's all.

---

Also, regarding the abstraction - I'm good with leaving it for another PR, so no stress (unless you'd really like to tackle it here already, then by all means 😄)

[andrewtavis]

Happy to move that to a new PR/issue or have it be committed here. @henrikth93, let me know which one you'd prefer and I'll get to the review soon if we're leaving as is 😊

[henrikth93]

Let us move that to a new issue! :)

[andrewtavis]

af9e726 removes the code that was commented out and also adds a char to Spanish and Swedish in one row as they had less than the others. Big thing that I'm realizing is that the Russian keyboard is automatically crashing at this point, but then this is the case on main as well 🤦‍♂️ I'll take a look at it. @henrikth93, as a final commit for this, do you want to change it so that the right shift key takes up the whole of the extra space as is done on the system German keyboard? See below:

I think that this would be the easiest way of figuring this all out 😊

[andrewtavis]

Looking into this now and making a checklist for myself to confirm that the UI is ready for things:

• French letters
• French alt chars
• German letters
• German letters (disable accent chars)
• German alt chars
• Italian letters
• Italian alt chars
• Portuguese letters
• Portuguese alt chars
• Note: something broke the Russian keyboard...
  • Fix it and document what happened
    • RussianKeyboardConstants.symbolKeysPadExpanded was assigned to letterKeys
• Russian letters
• Russian alt chars
• Spanish letters
• Spanish letters (disable accent chars)
• Spanish alt chars
• Swedish letters
• Swedish letters (disable accent chars)
• Swedish alt chars
• Add necessary characters to English, Danish, Norwegian and Hebrew

[andrewtavis]

Approved and on to the next issue! 🥳🚀

63d5ce1 has all kinds of changes coming through:

• I simplified how expanded keyboards are laid out such that we always have the same number of keys per row for all languages
  • Just felt it was easier than going in and adding all the padding
  • We can do this later if there's a demand
  • This included some general resizing of the special keys
• There was a bug that brome the Russian keyboard where ussianKeyboardConstants.symbolKeysPadExpanded was assigned to letterKeys rather than symbolKeys
• I made the height of expanded keyboards a bit larger
• The vertical space between the keys on expanded keyboards was decreased
• I removed the menu option for putting a period and a comma on the letter keys if the user is on an iPad
• Lots of keys were added across all keyboards 😊

Thanks so much for your dedication in working on this, @henrikth93! Really so great to have this finalized 🙌