Combine genders and plurals into comma separated strings for noun que…

[you-think-you-know-me]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the pytest command as directed in the testing section of the contributing guide

---

Description

Modified the SPARQL query for nouns for spanish language such that all gender and plurals associated with a lexmme are shown in a single row as comma separated string.

I have tested the query by running it at https://query.wikidata.org/.

Above image shows that for one lexmme there is only one result having combined comma separated string for gender and plural.

Related issue

Combine genders into comma separated strings for noun queries #544

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[github-actions]

First PR Commit Check

• The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo (can be set with git config --global user.email "GITHUB_EMAIL")

[andrewtavis]

Giving this another look, @you-think-you-know-me, I'm wondering if it might make more sense to handle this in post formatting. If we add this kind of group by functionality, then this will also need to go into the query generation functionality, and then it's also going to mean that the queries are going to be a lot slower. Would you have interest in reverting the changes to the query and then updating src/scribe_data/wikidata/format_data.py so that if the value already exists in the dictionary, that a new one will be appended with such that the new value is the old and new in alphabetical order separated by commas?

Let me know how this sounds! This will also mean that we won't have to change the queries one by one 😊

[you-think-you-know-me]

Giving this another look, @you-think-you-know-me, I'm wondering if it might make more sense to handle this in post formatting. If we add this kind of group by functionality, then this will also need to go into the query generation functionality, and then it's also going to mean that the queries are going to be a lot slower. Would you have interest in reverting the changes to the query and then updating src/scribe_data/wikidata/format_data.py so that if the value already exists in the dictionary, that a new one will be appended with such that the new value is the old and new in alphabetical order separated by commas?

Let me know how this sounds! This will also mean that we won't have to change the queries one by one 😊

Sounds good, I will make the required changes.

[andrewtavis]

Great! Looking forward to them :)

[you-think-you-know-me]

@andrewtavis I have made the required changes. Please review them.

[andrewtavis]

@you-think-you-know-me: Sorry there were pressing changes that needed to be brought in :) Would you be able to solve the merge conflicts on this PR? I can help as well if need be :) After that this PR will be the next to be brought in 🚀

[andrewtavis]

Sorry, closed on accident! Let me know on the rebase, and again happy to help 😊

[andrewtavis]

Discussing this with @axif0 right now: We may need to comma separate all responses that have the same form, not just gender and plurals :)

[andrewtavis]

Related issue for this is #573 :)

[andrewtavis]

@axif0 Will be doing a first review to combine the changes that were recently made to this file :)

[axif0]

[andrewtavis]

Thanks for the great contribution here @you-think-you-know-me and also for the amazing work to connect all of this and resolve #573 as well, @axif0! 🚀