Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Query Data adding Last Modified Date #566

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

axif0
Copy link
Collaborator

@axif0 axif0 commented Feb 2, 2025

Contributor checklist


Description

Added modified_date in data_formatted in Query Data.

Related issue

@axif0 axif0 requested a review from andrewtavis February 2, 2025 20:50
Copy link

github-actions bot commented Feb 2, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@wkyoshida wkyoshida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@@ -51,16 +51,18 @@ def format_data(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the changes already in the PR, should the changes also include modifying that new workflow that's being worked on, check_and_update_missing_query_forms.yaml? To also include the additional segments for lastModified in the generated queries?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True yes :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need the gender concatenations for #564 to be included in the query generations 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then I worry a bit about putting group by into all of the queries like this. Maybe the thing to do is handle this in the formatting script where basically values are concatenated if they're already present in the resulting data. Spanish nouns gender just isn't really a useful field with the way the data has been structured.

And also, I just remembered that @axif0 mentioned that this has been added to the other PR in e363282 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're good to go here :) :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also, I just remembered that @axif0 mentioned that this has been added to the other PR

Ah nice!
I hadn't seen that before - good stuff! 👍 way to go

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @axif0! Really appreciate that we're making so much progress on this already and building for sustainable API calls in the future 🚀😊

@andrewtavis
Copy link
Member

Re discussion in #566 (comment), e363282 added the requested changes to #563, so we are good to merge here and #562 will be closed when the other PR is brought in 🚀

@andrewtavis andrewtavis merged commit 7f5c39c into scribe-org:main Feb 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants