Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage report paths #907

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

AlexVCaron
Copy link
Contributor

Quick description

Paths between the source, the coverage report and codecov were muddled. I moved .coverage at the root, and now codecov can execute there and everything is golden.

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89ca33f) 0.00% compared to head (543d1c2) 65.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #907       +/-   ##
===========================================
+ Coverage    0.00%   65.95%   +65.95%     
===========================================
  Files         384      383        -1     
  Lines       21352    21345        -7     
  Branches     3495     3494        -1     
===========================================
+ Hits            0    14078    +14078     
+ Misses      21352     5660    -15692     
- Partials        0     1607     +1607     
Components Coverage Δ
Scripts 67.37% <ø> (+67.37%) ⬆️
Library 63.37% <ø> (+63.37%) ⬆️

@AlexVCaron AlexVCaron changed the title [WIP] Fix coverage report paths Fix coverage report paths Feb 16, 2024
@arnaudbore arnaudbore merged commit 065a43a into scilus:master Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants