Reformatting, use deleteNode when disposing #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kephale I'm happy to split out the formatting part of the commit, if you tell me your preferred way to perform the formatting. Using IntelliJ, presumably? Do I need to configure any rules, or does sciview use the default style? |
|
I'm not really picky about formatting in general, but some lines around the main change here were indented wrong so I had to run reformat. I did use IntelliJ and I thought we had some linting rules, but I haven't tracked those details very well. |
|
Replaced by #525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy to do later, leaving as WIP during the hackathon because I reformatted too.