Add @Parameter for Mesh's

[kephale]

No description provided.

[kephale]

@ctrueden questions about this (no rush):

1. Do we want the widget to be a dropdown menu of all meshes available in the currently active SciView window?
2. Would there be any obvious issues with coding this as something like MeshWidget that implements InputWidget which has an @Parameter for a SciView?
3. What is the best existing code snippet to reference for implementation?

[imagejan]

How about registering Meshes with the ObjectService when they're created/displayed? Then a ChoiceWidget would be created automatically (taking the toString() as a name, IIRC).

To also allow #@ Mesh in scripting, all you need is add an alias from Mesh to net.imagej.mesh.Mesh using ScriptService.addAlias()

[kephale]

! That sounds smart. We'll check it out.

…

On Thu, Mar 21, 2019 at 10:35 AM Jan Eglinger ***@***.***> wrote: How about registering Meshes with the ObjectService when they're created/displayed? Then a ChoiceWidget would be created automatically (taking the toString() as a name, IIRC). To also allow #@ Mesh in scripting, all you need is add an alias from Mesh to net.imagej.mesh.Mesh using ScriptService.addAlias() — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYa6Z8YHXzZxcLojIOGT7R6pDJDBOVNks5vY5iygaJpZM4YsODz> .

[kephale]

Thank you kindly @imagejan

Addressed in 90e2d52

[ctrueden]

Awesome, @kephale!

The only thing to watch out for is: ObjectService's index keeps hard refs, so your meshes will not be GCed unless you remove them explicitly. Maybe do that when they are removed from all scenes? You'll probably have to reference count, unfortunately.

Alternately, we could look at adding weak reference support to the object service. Let me know if that would help you.

[kephale]

This one is flagged for https://github.com/scenerygraphics/sciview/issues?q=is%3Aopen+label%3A1.0.0+sort%3Aupdated-desc to check the situation w.r.t. @ctrueden's comment

[kephale]

Node deletion also removes them from the ObjectService now.

I did notice that SciView.dispose() does not use deleteNode. That is important because there may be some memory reference issues with scenery's volume manager that @moreApi mentioned in another issue, and deleteNode also handles special case cleanup for Volumes, including removal from VolumeManager. This would be addressed by #478