Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3UTILS-54 crrExistingObjects is compatible with both S3C and Artesca #305

Merged
merged 1 commit into from
Apr 16, 2024

Commits on Apr 16, 2024

  1. S3UTILS-54 crrExistingObjects is compatible with both S3C and Artesca

    !! Warning !! : Breaking change for Zenko deployment only (XDM and Artesca): introduction of mandatory environment variables ACCESS_KEY, SECRET_KEY, and ENDPOINT
    
    The Pull Request introduces these key changes:
    
    Switch to S3 and Backbeat API: crrExistingObjects now uses S3 and Backbeat APIs instead of direct metadata calls, enhancing security and maintainability but potentially slowing down performance due to added abstraction. It's expected to be minor, but will undergo testing.
    
    Refactoring for testability: The script has been refactored to make it more modular and easier to test, improving code clarity and allowing for better unit/functional testing.
    
    Adding unit/functional tests with mocks: Unit/functional tests using mocked S3 and Backbeat APIs have been added, providing a controlled environment for more comprehensive and reliable testing of the script's functionality.
    nicolas2bert committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1cf6c9d View commit details
    Browse the repository at this point in the history