S3UTILS-54 crrExistingObjects is compatible with both S3C and Artesca #305
Conversation
Hello nicolas2bert,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
nicolas2bert
changed the title
nicolas2bert
force-pushed
the
improvement/S3UTILS-54/merge2
branch
2 times, most recently
from
b42df13
to
b0e964c
Compare
nicolas2bert
force-pushed
the
improvement/S3UTILS-54/merge2
branch
from
b574630
to
13f9153
Compare
nicolas2bert
changed the base branch from
development/1.14
to
development/1.15
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
nicolas2bert
force-pushed
the
improvement/S3UTILS-54/merge2
branch
from
13f9153
to
76e23ec
Compare
tests/unit/CRR/crrExistingObjects.js
Outdated
| process.exit.mockReset(); | ||
|
|
||
| // Clear the mocks before each test | ||
| // ReplicationStatusUpdater.mockClear(); |
!! Warning !! : Breaking change for Zenko deployment only (XDM and Artesca): introduction of mandatory environment variables ACCESS_KEY, SECRET_KEY, and ENDPOINT The Pull Request introduces these key changes: Switch to S3 and Backbeat API: crrExistingObjects now uses S3 and Backbeat APIs instead of direct metadata calls, enhancing security and maintainability but potentially slowing down performance due to added abstraction. It's expected to be minor, but will undergo testing. Refactoring for testability: The script has been refactored to make it more modular and easier to test, improving code clarity and allowing for better unit/functional testing. Adding unit/functional tests with mocks: Unit/functional tests using mocked S3 and Backbeat APIs have been added, providing a controlled environment for more comprehensive and reliable testing of the script's functionality.
nicolas2bert
force-pushed
the
improvement/S3UTILS-54/merge2
branch
from
76e23ec
to
1cf6c9d
Compare
|
@bert-e approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3UTILS-54. Goodbye nicolas2bert. The following options are set: approve |
The Pull Request introduces these key changes:
Switch to S3 and Backbeat API: crrExistingObjects now uses S3 and Backbeat APIs instead of direct metadata calls, improving security and maintainability but potentially slowing down performance due to added abstraction. It's expected to be minor, but will undergo testing.
Refactoring for testability: The script has been refactored to make it more modular and easier to test, improving code clarity and allowing for better unit/functional testing.
Adding unit/functional tests with mocks: Unit/functional tests using mocked S3 and Backbeat APIs have been added, providing a controlled environment for more comprehensive and reliable testing of the script's functionality.
Note: Additional modifications are required in both CloudServer and Backbeat:
https://scality.atlassian.net/browse/CLDSRV-501
https://scality.atlassian.net/browse/BB-483
!! Warning !! : Breaking change for Zenko deployment only (XDM and Artesca): introduction of mandatory environment variables ACCESS_KEY, SECRET_KEY, and ENDPOINT