-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ScalarDB SNAPSHOT versions in ScalarDB Jepsen test #109
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,11 +69,11 @@ | |
(reify | ||
TwoPhaseCommitTransaction | ||
(getId [_] "dummy-id") | ||
(^Optional get [_ ^Get _] (throw (CrudException. "get failed"))) | ||
(^void put [_ ^Put _] (throw (CrudException. "put failed"))) | ||
(^void prepare [_] (throw (PreparationException. "preparation failed"))) | ||
(^void validate [_] (throw (ValidationException. "validation failed"))) | ||
(^void commit [_] (throw (CommitException. "commit failed"))) | ||
(^Optional get [_ ^Get _] (throw (CrudException. "get failed" nil))) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to make this change because the constructors of these exceptions have been changed. |
||
(^void put [_ ^Put _] (throw (CrudException. "put failed" nil))) | ||
(^void prepare [_] (throw (PreparationException. "preparation failed" nil))) | ||
(^void validate [_] (throw (ValidationException. "validation failed" nil))) | ||
(^void commit [_] (throw (CommitException. "commit failed" nil))) | ||
(^void rollback [_] (swap! rollback-count inc)))) | ||
|
||
(def mock-2pc-throws-unknown | ||
|
@@ -84,7 +84,7 @@ | |
(^void put [_ ^Put p] (mock-put p)) | ||
(^void prepare [_] (swap! prepare-count inc)) | ||
(^void validate [_] (swap! validate-count inc)) | ||
(^void commit [_] (throw (UnknownTransactionStatusException. "unknown state"))) | ||
(^void commit [_] (throw (UnknownTransactionStatusException. "unknown state" nil))) | ||
(^void rollback [_] (swap! rollback-count inc)))) | ||
|
||
(deftest append-client-init-test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a comment for the
user-jars
.Do you think you want to keep
use-jars
?I feel we can delete it since it's bothersome to maintain the packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Let's delete it in another PR. Thanks.