Use ScalarDB SNAPSHOT versions in ScalarDB Jepsen test #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
use-snapshot-versions-in-scalardb-jepsen-test
branch
from
56a482e
to
363d7f9
Compare
inv-jishnu
approved these changes
Aug 1, 2023
brfrn169
commented
Aug 4, 2023
| (^void prepare [_] (throw (PreparationException. "preparation failed"))) | ||
| (^void validate [_] (throw (ValidationException. "validation failed"))) | ||
| (^void commit [_] (throw (CommitException. "commit failed"))) | ||
| (^Optional get [_ ^Get _] (throw (CrudException. "get failed" nil))) |
There was a problem hiding this comment.
We need to make this change because the constructors of these exceptions have been changed.
feeblefakie
approved these changes
Aug 4, 2023
| :profiles {:dev {:dependencies [[tortue/spy "2.0.0"]] | ||
| :plugins [[lein-cloverage "1.1.2"]]} | ||
| :use-released {:dependencies [[com.scalar-labs/scalardb "3.7.0" | ||
| :use-released {:dependencies [[com.scalar-labs/scalardb "4.0.0-SNAPSHOT" |
There was a problem hiding this comment.
It's a comment for the user-jars.
Do you think you want to keep use-jars?
I feel we can delete it since it's bothersome to maintain the packages.
There was a problem hiding this comment.
Agreed. Let's delete it in another PR. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look!