Fix glossary term matching for Japanese docs #882
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the component
GlossaryInjector
, which is used for showing terms in the glossary across pages. The problem was that many glossary terms were not showing on Japanese pages because those terms weren't detected with/without plurals, which was specific to only English terms. The problem occurred after introducing support for glossary terms in plural form in #834.To fix this issue, I've refactored glossary term detection to better handle Japanese language pages by avoiding word boundaries and pluralization logic that are not applicable. This ensures accurate glossary injection for both English and Japanese documentation.
Related issues and/or PRs
Changes made
isJapaneseSite
flag: Added a flag to detect if the current site is Japanese (/ja-jp/
) and reused this flag across multiple sections for cleaner and consistent logic. ([1], [2])Checklist
Additional notes (optional)
N/A