Skip to content

Fix false-positive matches for glossary terms #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

josh-wong
Copy link
Member

@josh-wong josh-wong commented Jun 25, 2025

Description

This pull request fixes the regex logic in the GlossaryInjector component to improve term matching for both Japanese and English text. The changes enhance accuracy by addressing language-specific nuances and edge cases, particularly in cases where part of a word (like ca) shows a tooltip in a longer term (like Scalar).

Related issues and/or PRs

Changes made

Language-specific term-matching improvements

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have updated the side navigation as necessary.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Fixes instances where a word that is part of another word is incorrectly flagged (like `ca` showing a tooltip in the word `Scalar`).
@josh-wong josh-wong self-assigned this Jun 25, 2025
@josh-wong josh-wong added the bugfix Fix that resolves bugs label Jun 25, 2025
@josh-wong josh-wong merged commit fef09c1 into main Jun 25, 2025
1 check passed
@josh-wong josh-wong deleted the fix-false-positives-in-tooltips branch June 25, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix that resolves bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant