Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a formula for VirtusLab #1745

Closed
wants to merge 1 commit into from
Closed

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Feb 6, 2025

I was prompted to add some info about work sponsored by VirtusLab

@tgodzik tgodzik requested a review from adpi2 February 6, 2025 16:12
@@ -64,6 +64,8 @@ Further reading:

### Experimental WebAssembly backend in Scala.js

*By the Scala Open Source team at VirtusLab*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Rikito wrote some of this, but if I am mistaken let me know.

Copy link
Member

@SethTisue SethTisue Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if readers might get confused whether "by" refers to who wrote the newsletter section, or who did the engineering work being described?

I'm uncertain myself, actually, which one is intended...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to add a whole new formula, just similar in case of jetbrains, which I think is about who wrote that section? We added the sections for Scala CLI and Metals, so figured it's enough to mention it. Wasn't sure about WASM though.

I can also change it to Work mostly done by VirtusLab Open Source Team, but that seems too on the nose.

@adpi2
Copy link
Member

adpi2 commented Feb 7, 2025

Please see my other PR in #1747 which should address this issue

@SethTisue
Copy link
Member

yeah let's go with some form of #1747

@SethTisue SethTisue closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants