-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve website organization #1147
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 84.43% 76.27% -8.16%
==========================================
Files 97 97
Lines 7673 7677 +4
==========================================
- Hits 6479 5856 -623
- Misses 1194 1821 +627
Flags with carried forward coverage won't be shown. Click here to find out more. |
Note: for building the docs site locally I needed to run the following commands in an empty condo env with pip install -e ".[doc,dev]"
pip install jupyter_contrib_nbextensions
pip install --upgrade notebook==6.4.12
pip uninstall traitlets
pip install traitlets==5.9.0
pip uninstall ipython
pip install ipython==8.9.0 ... mkdocs serve I believe this is due to our custom Jupyter notebook extensions (e.g., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks a lot!
I added some comments and pushed 2 commits implementing some of my suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comment, I will take another look at the mkdocs-jupyter
extension in the afternoon
@tomMoral I made some edits here:
What do think of those? And I have a couple of comments / questions:
We could also arrange a video call to discuss. |
I finally got some time to take a look at this one. I just pushed 2 small changes, one adding a link to "get started" tutorial on the front page. Feel free to revert if you don't like it. As for
This is really as you prefer for the workflow. |
Hi @tomMoral thanks for the update! It looks good. I made a couple of smaller changes:
Two points remain:
|
@tomMoral In the last commit I made a couple of naive changes to the workflow file, all up for discussion:
Does that make sense? |
|
TODO for setting up
|
@michaeldeistler can you please give this a final review? To do so
See also PR description on top which summarizes all the changes. |
Related to doc improvements described in #1008
Summary of the changes
New
docs
workflow withmike
mike
allows us to have differentdocs
versions in parallelwe want to have one
dev
version showing the docs of themain
branch (unreleased), and onelatest
version showing the docs of the latest releasethe website docs should always show the
latest
versionwhenever we push to
main
, thedev
version is updated:tutorials
andexamples
notebooks are converted into markdown and the docs files are created usingmkdocs build
whenever we publish a new release, the same thing happens, but the
latest
docs is updated (-u
option in the command) to the new release and deployed on the website.