Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the structure of the documentation and website #1166

Open
janfb opened this issue Jun 11, 2024 · 3 comments
Open

Improving the structure of the documentation and website #1166

janfb opened this issue Jun 11, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation hackathon karma Karma issues: potentially annoying but very important issues

Comments

@janfb
Copy link
Contributor

janfb commented Jun 11, 2024

Our documentation has grown organically. During the March 2024 hackathon we made a lot of improvements on the content and currently we are working on improving the website accordingly, see #1147 .

However, I came across this guide: https://diataxis.fr/

I could be a good starting point for generally improving the structure of our documentation website. I think that's a bigger project, maybe something for the next SBI sprint / hackathon.

@janfb janfb added documentation Improvements or additions to documentation less-urgent This is beyond the current 2 week horizon karma Karma issues: potentially annoying but very important issues labels Jun 11, 2024
@janfb
Copy link
Contributor Author

janfb commented Aug 6, 2024

more sources for inspiration:

@evavanweenen
Copy link

Hi,

I'm a relatively low-level user of sbi and find it sometimes difficult to browse the API reference of the documentation. The point where I'm having most trouble is the link between code and documentation. I'm having trouble finding where to import something in my code if I see it in the API documentation and vice versa, I'm having trouble finding the documentation for something that I have imported in my code.

I'll write a few points below what I experienced and what could potentially be improved:

  • For instance, if I want to look up the documentation for a trainer (NPE, NLE, etc.), it's not straightforward where to look in the documentation. The documentation for trainers is looked in the Inference part of the API documentation. In a similar example, the sbi.utils.process_prior function is under Inference in the documentation. Similarly, Posterior has its own heading in the documentation, but the posteriors are imported from sbi.inference.posteriors. Consistent naming would help here.
  • It would also help a lot if the documentation followed the style of for instance pytorch, where you see the full path to the function and its arguments (e.g. torch.distributions.normal.Normal(loc, scale, validate_args=None) instead of Normal), so I know how to import this class/function in my code.
  • The table of contents on the right-hand side could be cleaned up (e.g. removing private functions, merging init documentation with class documentation, sorting it).
  • For some parts there is no documentation, for instance for the estimators. It would be great if there is documentation for all parts of SBI.

I think many suggestions could be relatively easily changed by changing settings from mkdocstrings (assuming that is what is used to build the documentation).

Thanks! :) (And so far I've really enjoyed using SBI.)

@janfb
Copy link
Contributor Author

janfb commented Jan 23, 2025

Hi @evavanweenen

thanks a lot for this feedback! This is very helpful. We will have a look at this at the hackathon in March.

@janfb janfb added hackathon and removed less-urgent This is beyond the current 2 week horizon labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hackathon karma Karma issues: potentially annoying but very important issues
Projects
None yet
Development

No branches or pull requests

2 participants