Skip to content

Commit

Permalink
Fix asan.test_asyncify_longjmp (emscripten-core#20740)
Browse files Browse the repository at this point in the history
This test started failing after the compiler-rt upgrade because we
started depending on the `getrlimit` syscall, and this test builds in
`-sSTRICT` mode which disables `ALLOW_UNIMPLEMENTED_SYSCALLS` which
means stub syscalls are not included.
  • Loading branch information
sbc100 authored Nov 17, 2023
1 parent da8fe5f commit 28a09f6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,7 @@ jobs:
asan.test_cubescript
asan.test_wasm_worker_hello
asan.test_externref_emjs_dynlink
asan.test_asyncify_longjmp
lsan.test_stdio_locking
lsan.test_dlfcn_basic
lsan.test_pthread_create"
Expand Down
2 changes: 2 additions & 0 deletions system/lib/compiler-rt/lib/asan/asan_rtl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,9 @@ static void AsanInitInternal() {

ReplaceSystemMalloc();

#if !SANITIZER_EMSCRIPTEN
DisableCoreDumperIfNecessary();
#endif

InitializeShadowMemory();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ bool DontDumpShadowMemory(uptr addr, uptr length) {
#endif // MADV_DONTDUMP
}

#if !SANITIZER_EMSCRIPTEN
static rlim_t getlim(int res) {
rlimit rlim;
CHECK_EQ(0, getrlimit(res, &rlim));
Expand Down Expand Up @@ -127,6 +128,7 @@ void SetAddressSpaceUnlimited() {
setlim(RLIMIT_AS, RLIM_INFINITY);
CHECK(AddressSpaceIsUnlimited());
}
#endif

void Abort() {
#if !SANITIZER_GO
Expand Down

0 comments on commit 28a09f6

Please sign in to comment.