Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use nested parameterization in test_sdl_key. NFC (emscripten-core#20738)
I'm tying this out as an experiment. I think it improves things in several ways: - Increases precision of tests - Aids in debugging (makes run just one code path much easier) - Cleaner test output as tests no longer have to `print()` each time they go around the loop (which was a crutch to help identify which iteration failed). Now this single test has 8 different configurations (the 9th test here, test_sdl_key_proxy, is actually a different test): ``` $ ./test/runner browser.test_sdl_key* Test suites: ['test_browser'] Running test_browser: (9 tests) (checking sanity from test runner) shared:INFO: (Emscripten: Running sanity checks) [Browser harness server on process 858049] common:INFO: Using default system browser Running the browser tests. Make sure the browser allows popups from localhost. test_sdl_key (test_browser.browser.test_sdl_key) ... ok test_sdl_key_asyncify (test_browser.browser.test_sdl_key_asyncify) ... ok test_sdl_key_asyncify_eventhandler (test_browser.browser.test_sdl_key_asyncify_eventhandler) ... ok test_sdl_key_delay (test_browser.browser.test_sdl_key_delay) ... ok test_sdl_key_delay_asyncify (test_browser.browser.test_sdl_key_delay_asyncify) ... ok test_sdl_key_delay_asyncify_eventhandler (test_browser.browser.test_sdl_key_delay_asyncify_eventhandler) ... ok test_sdl_key_delay_eventhandler (test_browser.browser.test_sdl_key_delay_eventhandler) ... ok test_sdl_key_eventhandler (test_browser.browser.test_sdl_key_eventhandler) ... ok test_sdl_key_proxy (test_browser.browser.test_sdl_key_proxy) ... ok [Browser harness server terminated] ```
- Loading branch information