-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: urlencode filename for separate mod targets #47
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## staging #47 +/- ##
===========================================
- Coverage 16.94% 16.94% -0.01%
===========================================
Files 103 103
Lines 5440 5442 +2
===========================================
Hits 922 922
- Misses 4417 4419 +2
Partials 101 101 ☔ View full report in Codecov by Sentry. |
The linter is failing because of missing whitespace around the Can you also fix the similar issue in Line 279 in 4c5629d
|
I think that should be it EDIT: I ran |
When a mod's name contains characters that should be urlencoded, any newly-uploaded versions cannot be download because of some errors regarding the URL being invalid. Make sure the returned key is urlencoded for consistency with the rest of the codebase. Signed-off-by: Angel Pons <[email protected]>
As per Mircea's comment on [satisfactorymodding#44 (comment)](satisfactorymodding#44 (comment)): I've also now noticed that RenameVersion is also not correctly escaping the filename, it's only escaping the mod's name, and not the version, which is what causes mods that use build metadata in the version (+build.1234) to fail, so that one should need a similar fix of encoding the filename. Signed-off-by: Angel Pons <[email protected]>
When a mod's name contains characters that should be urlencoded, any newly-uploaded versions cannot be download because of some errors regarding the URL being invalid. Make sure the returned key is urlencoded for consistency with the rest of the codebase.