fix: urlencode version in RenameFilename

Th3Fanbus · Th3Fanbus · commit f323a9ffacb2 · 2024-03-06T08:56:50.000+01:00
As per Mircea's comment on [#44 (comment)](#44 (comment)): I've also now noticed that RenameVersion is also not correctly escaping the filename, it's only escaping the mod's name, and not the version, which is what causes mods that use build metadata in the version (+build.1234) to fail, so that one should need a similar fix of encoding the filename. Signed-off-by: Angel Pons <th3fanbus@gmail.com>
diff --git a/storage/storage.go b/storage/storage.go
@@ -276,7 +276,7 @@ func RenameVersion(ctx context.Context, modID string, name string, versionID str
 		return false, ""
 	}
 
-	return true, fmt.Sprintf("/mods/%s/%s.smod", modID, EncodeName(cleanName)+"-"+version)
+	return true, fmt.Sprintf("/mods/%s/%s.smod", modID, EncodeName(cleanName+"-"+version))
 }
 
 func DeleteMod(ctx context.Context, modID string, name string, versionID string) bool {

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ func RenameVersion(ctx context.Context, modID string, name string, versionID str`
`276`	`276`	`return false, ""`
`277`	`277`	`}`
`278`	`278`
`279`		`- return true, fmt.Sprintf("/mods/%s/%s.smod", modID, EncodeName(cleanName)+"-"+version)`
	`279`	`+ return true, fmt.Sprintf("/mods/%s/%s.smod", modID, EncodeName(cleanName+"-"+version))`
`280`	`280`	`}`
`281`	`281`
`282`	`282`	`func DeleteMod(ctx context.Context, modID string, name string, versionID string) bool {`