Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lock file v4 #29

Open
nazar-pc opened this issue Oct 28, 2024 · 3 comments
Open

Support for lock file v4 #29

nazar-pc opened this issue Oct 28, 2024 · 3 comments

Comments

@nazar-pc
Copy link

Right now lock files with version = 4 created by nightly versions fail like this:

error: not found: Couldn't load Cargo.lock
Caused by:
  -> I/O operation failed: parse error: parse error: invalid Cargo.lock format version: `4`

Would be great to support this, especially if this is not a big lift.

@tarcieri
Copy link
Member

Dup of rustsec/rustsec#1249

@tarcieri tarcieri closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
@Shnatsel
Copy link
Member

Reopening now that cargo audit supports lockfile v4, but this action reportedly doesn't.

@Shnatsel Shnatsel reopened this Nov 28, 2024
@nazar-pc
Copy link
Author

nazar-pc commented Nov 28, 2024

It kind of does and doesn't at the same time, which I believe is caused by this line:

await cargo.findOrInstall('cargo-audit');

It will not try to upgrade cargo-audit when older version that doesn't support v4 lock file is currently installed. This doesn't affect official runners in most cases, but it may affect self-hosted runners that do not clean the state or simply workflows that happen to have cargo-audit of older version installed for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants