ci: FREE CARGO-AUDIT!

[storopoli]

Description

Now that rustsec/rustsec#1249 is closed, we are free to unpin cargo-audit.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactor
• New or updated tests
• Update Dependencies

Checklist

• I have performed a self-review of my code.
• I have commented my code where necessary.
• I have updated the documentation if needed.
• My changes do not introduce new warnings.
• I have added tests that prove my changes are effective or that my feature works.
• New and existing tests pass with my changes.

Related Issues

STR-601

[storopoli]

I think we're hitting rustsec/audit-check#29 in CI failures

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.40%. Comparing base (0ea3c38) to head (710ced1).
Report is 16 commits behind head on main.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   56.45%   58.40%   +1.95%     
==========================================
  Files         273      277       +4     
  Lines       29079    29287     +208     
==========================================
+ Hits        16416    17105     +689     
+ Misses      12663    12182     -481     

see 70 files with indirect coverage changes

[Rajil1213]

I think we're hitting rustsec/audit-check#29 in CI failures

I think @prajwolrg has seen this issue before. I don't remember how we fixed it though. Re-running the CI job just to rule out any transient issues.

[prajwolrg]

I think we're hitting rustsec/audit-check#29 in CI failures

I think @prajwolrg has seen this issue before. I don't remember how we fixed it though. Re-running the CI job just to rule out any transient issues.

There was similar issue earlier. AFAIK we fixed it by locking to earlier version. @sapinb did most of the work here.

[delbonis]

We say we're not denying warnings but then we do -D warnings?

[Rajil1213]

It's not part of the diff but there is a line that ignores any warnings:

https://github.com/alpenlabs/strata/blob/34a660a5a84521c54613f7659f29144e4de8f3a1/.github/workflows/security.yml#L30C1-L31C32

[storopoli]

Closing this... tried to run CI again and it's broken

[storopoli]

Blocked by rustsec/audit-check#29

[storopoli]

Ok still broken!

[storopoli]

I'm closing this since rebasing Cargo.lock is a PITA.