Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde encoding improvements #3184

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Serde encoding improvements #3184

merged 2 commits into from
Oct 28, 2024

Conversation

nazar-pc
Copy link
Member

This implements serialization as hex only for human-readable formats, serializing the rest as binary. I also simplified handling of types like Piece and PosProof.

Code contributor checklist:

Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense overall. I would add tests for serializing/deserializing but it's not a blocker since the code is not complex.

@nazar-pc
Copy link
Member Author

Manually edited lock file to work around rustsec/audit-check#29 for now

@nazar-pc nazar-pc added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 1aad248 Oct 28, 2024
10 checks passed
@nazar-pc nazar-pc deleted the serde-encoding-improvements branch October 28, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants