Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: 0.25.0 -> 0.26.0 #59

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Cargo: 0.25.0 -> 0.26.0 #59

merged 1 commit into from
Mar 22, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 21, 2024

Preparation to cut a new 0.26.0 release to bring in changes since 0.25.

This repo doesn't have an established CHANGELOG or GitHub releases, but the major callouts I would include would be:

Additions

Fixes

@jbr
Copy link
Contributor

jbr commented Mar 21, 2024

Would this include a release of futures-rustls as well? I think it has an identical changelist, although it was all done in one PR. One advantage of #58 is that releases could be synchronized in a workspace repo

@cpu
Copy link
Member Author

cpu commented Mar 21, 2024

Would this include a release of futures-rustls as well?

Sure, I can prepare a release over there as well 👍

Edit: rustls/futures-rustls#11

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I think we should just do GitHub releases like we do in the other crates. I'd probably list the 0.23 upgrade first, seems like the most important part? Also maybe coalesce all the crypto provider stuff in a single bullet? It's really mostly aligning with upstream and not actually much of a change for this crate IMO.

@cpu
Copy link
Member Author

cpu commented Mar 21, 2024

I think we should just do GitHub releases like we do in the other crates.

I agree, but I can't commit to creating releases for each of the previous tags this evening. I would be open to creating a new one for 0.26.0 if folks are interested in that.

I'd probably list the 0.23 upgrade first, seems like the most important part? Also maybe coalesce all the crypto provider stuff in a single bullet? It's really mostly aligning with upstream and not actually much of a change for this crate IMO.

SGTM. Updated!

@djc
Copy link
Member

djc commented Mar 21, 2024

I agree, but I can't commit to creating releases for each of the previous tags this evening. I would be open to creating a new one for 0.26.0 if folks are interested in that.

No, I just meant for this one.

@cpu cpu requested a review from quininer March 21, 2024 21:29
@quininer quininer merged commit 82b4a3e into rustls:main Mar 22, 2024
6 checks passed
@quininer
Copy link
Member

Thank you!

@djc
Copy link
Member

djc commented Mar 22, 2024

Published tokio-rustls v0.26.0 at registry crates-io, published a release at https://github.com/rustls/tokio-rustls/releases/tag/v%2F0.26.0.

@cpu cpu deleted the cpu-0.26 branch March 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants