-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo: 0.25.0 -> 0.26.0 #59
Conversation
Would this include a release of futures-rustls as well? I think it has an identical changelist, although it was all done in one PR. One advantage of #58 is that releases could be synchronized in a workspace repo |
Sure, I can prepare a release over there as well 👍 Edit: rustls/futures-rustls#11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! I think we should just do GitHub releases like we do in the other crates. I'd probably list the 0.23 upgrade first, seems like the most important part? Also maybe coalesce all the crypto provider stuff in a single bullet? It's really mostly aligning with upstream and not actually much of a change for this crate IMO.
I agree, but I can't commit to creating releases for each of the previous tags this evening. I would be open to creating a new one for 0.26.0 if folks are interested in that.
SGTM. Updated! |
No, I just meant for this one. |
Thank you! |
Published tokio-rustls v0.26.0 at registry |
Preparation to cut a new 0.26.0 release to bring in changes since 0.25.
This repo doesn't have an established CHANGELOG or GitHub releases, but the major callouts I would include would be:
Additions
fips
feature - by @BiagioFesta in Cargo.toml: add aws-lc-rs feature as crypto backend #43, @jbr in feat: add fips pass-through feature #49, feat: change default crypto provider to match rustls' #50Fixes
NotConnected
error inpoll_shutdown
- by @djc in Ignore NotConnected error in poll_shutdown() #42ErrorKind::WouldBlock
inMidHandshake::SendAlert
poll - by @jbr in fix: check for ErrorKind::WouldBlock in MidHandshake::SendAlert poll #47ErrorKind::WouldBlock
inLayzConfigAcceptor
- by @jbr in Fix: Check for ErrorKind::WouldBlock in LazyConfigAcceptor #48SendAlert
io::ErrorKind
- by @jbr in fix: correctly poll alert.write until it finishes #52alert.write
poll - by @jbr in Fix: SendAlert io::ErrorKind should be InvalidData instead of Other #51