Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to rustls v0.23 #22

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Bump to rustls v0.23 #22

merged 2 commits into from
Apr 2, 2024

Conversation

aumetra
Copy link
Contributor

@aumetra aumetra commented Mar 2, 2024

WIP since it's blocked by the tokio-rustls upgrade

Also bumped the env_logger dependency since that was also out-of-date. But that's minor since it's only a test dependency.


Passes tests locally with my PostgreSQL instance.

@aumetra
Copy link
Contributor Author

aumetra commented Mar 2, 2024

(Will remove the patch from the Cargo.toml as soon as tokio-rustls is upgraded and released)

@serprex
Copy link
Contributor

serprex commented Mar 21, 2024

@aumetra thanks, the PR you linked is merged, could you please update the PR to drop the patch?

@aumetra
Copy link
Contributor Author

aumetra commented Mar 21, 2024

could you please update the PR to drop the patch?

Would love to but a new version hasn't been released to crates.io yet, so the best thing I could do is update the Git revision it's pointing to.

Without a tokio-rustls release, I can't remove the patch. Sorry

@aumetra
Copy link
Contributor Author

aumetra commented Mar 21, 2024

@djc Sorry for the ping, but do you have any insights why the new release of tokio-rustls is still pending?

@cpu
Copy link

cpu commented Mar 21, 2024

@aumetra Thanks for following up. Working on this in rustls/tokio-rustls#59

@aumetra aumetra marked this pull request as ready for review March 22, 2024 13:59
@aumetra
Copy link
Contributor Author

aumetra commented Mar 22, 2024

@serprex Done. Bumped to the released version and removed the patch.

@aumetra
Copy link
Contributor Author

aumetra commented Mar 27, 2024

@jbg sorry for the ping, but does this look good?

@jbg
Copy link
Owner

jbg commented Apr 2, 2024

Thanks @aumetra!

@jbg jbg merged commit 5f7b02e into jbg:master Apr 2, 2024
@aumetra aumetra deleted the rustls-0.23 branch April 2, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants